[INS-207] Add Role-Aware Resumption Support for Legacy S3 Scan #4600
+188
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MuneebUllahKhan222
changed the title
amanfcp
approved these changes
Dec 11, 2025
Contributor
amanfcp
left a comment
amanfcp
left a comment
There was a problem hiding this comment.
Looks fine to me..
Though I think an integration test is a must for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Legacy S3 scanning previously tracked resumption state using only the bucket name. This caused incorrect behavior when multiple configured roles had access to the same bucket, but with different object-level permissions.
In such cases, resumption could not reliably determine which role’s progress was being resumed.
This PR updates the legacy resumption logic to store and retrieve state using both the bucket name and the role ARN, aligning behavior with the newer unit-scan implementation.
Checklist:
make test-community)?make lintthis requires golangci-lint)?