Skip to content

Reduce False Positives in Twilio Detector #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shahzadhaider1 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Reduce False Positives in Twilio Detector #4516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
911dd63
added contextual keywords in regex and removed unnecessary detector k…
shahzadhaider1 Oct 23, 2025
5ba3645
Merge branch 'main' into INS-65-enhance-twilio-detector
shahzadhaider1 Oct 23, 2025
7dfc3d6
added more keywords in the regex prefix
shahzadhaider1 Oct 24, 2025
594676e
Merge branch 'main' into INS-65-enhance-twilio-detector
shahzadhaider1 Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions pkg/detectors/twilio/twilio.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ var _ detectors.Detector = (*Scanner)(nil)

var (
defaultClient = common.SaneHttpClient()
sidPat = regexp.MustCompile(`\bAC[0-9a-f]{32}\b`)
keyPat = regexp.MustCompile(`\b[0-9a-f]{32}\b`)
sidPat = regexp.MustCompile(detectors.PrefixRegex([]string{"twilio", "account", "id", "sid"}) + `\b(AC[0-9a-f]{32})\b`)
keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"twilio", "auth", "token", "secret", "key"}) + `\b([0-9a-f]{32})\b`)
)

type serviceResponse struct {
Expand All @@ -49,18 +49,20 @@ func (s Scanner) getClient() *http.Client {
// Keywords are used for efficiently pre-filtering chunks.
// Use identifiers in the secret preferably, or the provider name.
func (s Scanner) Keywords() []string {
Copy link
Contributor

@martinlocklear martinlocklear Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really think we need to have unit test coverage the covers this case, especially since it's already been causing problems, just to prevent regressions in the future (and make absolutely clear why we're making this change).

return []string{"sid", "twilio"}
return []string{"twilio"}
}

// FromData will find and optionally verify Twilio secrets in a given set of bytes.
func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (results []detectors.Result, err error) {
dataStr := string(data)

keyMatches := keyPat.FindAllString(dataStr, -1)
sidMatches := sidPat.FindAllString(dataStr, -1)
keyMatches := keyPat.FindAllStringSubmatch(dataStr, -1)
sidMatches := sidPat.FindAllStringSubmatch(dataStr, -1)

for _, sid := range sidMatches {
for _, key := range keyMatches {
for _, sidMatch := range sidMatches {
sid := sidMatch[1]
for _, keyMatch := range keyMatches {
key := keyMatch[1]
s1 := detectors.Result{
DetectorType: detectorspb.DetectorType_Twilio,
Raw: []byte(sid),
Expand Down
1 change: 1 addition & 0 deletions pkg/detectors/twilioapikey/twilioapikey.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result
for _, apiKey := range apiKeyMatches {
for _, secret := range secretMatches {
s1 := detectors.Result{
// TODO: We need to use the correct DetectorType here; detectorspb.DetectorType_TwilioApiKey
DetectorType: detectorspb.DetectorType_Twilio,
Raw: []byte(apiKey),
RawV2: []byte(apiKey + secret),
Expand Down