Fix parsing issues on 32-bit hosts #86006
Open
+13
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were mostly bugs with code of the following form: ``` if uint64Value < (... literal expression ...) ``` Swift's comparison operators allow their left- and right-hand sides to be of different widths. This in turn means that the literal expression above typically gets typechecked by default as a plain `Int` or `UInt` expression. In a number of cases, this led to truncation on platforms where `Int` is not 64 bits. In particular, this seems to fix tests on wasm32.
Contributor
Author
|
@swift-ci Please test |
Contributor
Author
|
This is a follow-on to #85797 |
tbkka
commented
Dec 12, 2025
| expectRoundTrip(Float16.nan) | ||
| expectRoundTrip(-Float16.nan) | ||
| expectRoundTrip(Float16(nan:73, signaling:false)) | ||
| #if !arch(wasm32) |
Contributor
Author
There was a problem hiding this comment.
WASM32 doesn't seem to like signaling NaNs for Float16.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were mostly bugs with code of the following form:
Swift's comparison operators allow their left- and right-hand sides to be of different widths. This in turn means that the literal expression above typically gets typechecked by default as a plain
IntorUIntexpression. In a number of cases, this led to truncation on platforms whereIntis not 64 bits.In particular, this seems to fix tests on wasm32.