Skip to content

[v25.x] deps: V8: cherry-pick highway@dcc0ca1cd42 #61008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
richardlau wants to merge 1 commit into
base: v25.x-staging
Choose a base branch
from
Open

[v25.x] deps: V8: cherry-pick highway@dcc0ca1cd42 #61008

richardlau wants to merge 1 commit into from
+104 −65

Conversation

@richardlau
Copy link
Member

@richardlau richardlau commented Dec 9, 2025

Original commit message:

Fix for GCC 15 compiler error on PPC8/PPC9/PPC10

Refs: google/highway@dcc0ca1
Refs: google/highway#2443
Fixes: #60992

Change is already on main. Needs to land on v25.x-staging and v24.x-staging (as per usual guidelines, should be released in Node.js 25 first for two weeks before release in Node.js 24).

@richardlau
deps: V8: cherry-pick highway@dcc0ca1cd42
26d6653 
Original commit message:

    Fix for GCC 15 compiler error on PPC8/PPC9/PPC10

Refs: google/highway@dcc0ca1
@richardlau richardlau added v8 engine Issues and PRs related to the V8 dependency. ppc Issues and PRs related to the Power architecture. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch. lts-watch-v24.x PRs that may need to be released in v24.x labels Dec 9, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Dec 9, 2025
@richardlau richardlau mentioned this pull request Dec 9, 2025
Open
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70456/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6917/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6917/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 9, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6917/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70465/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 10, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/70467/

@richardlau
Copy link
Member Author

richardlau commented Dec 10, 2025

It looks like the persistent es-module/test-typescript failure on AIX is also happening on v25.x-staging: https://ci.nodejs.org/job/node-test-commit-aix/60144/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run. ppc Issues and PRs related to the Power architecture. v8 engine Issues and PRs related to the V8 dependency. v25.x Issues that can be reproduced on v25.x or PRs targeting the v25.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@richardlau @nodejs-github-bot @cjihrig @aduh95 @juanarbol