Reorder Array#reduce overloads for better type inference #62878
Closed
+35
−36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reorders the
Array#reduceandArray#reduceRightmethod overloads to fix incorrect type inference when the initial value type differs from the array element type.Problem
When using
reducewith aninitialValuewhose typeUis assignable to the array element typeT(e.g.,numberassignable to{}), TypeScript incorrectly matches thereduce(callbackfn, initialValue: T): Toverload instead of the more specific genericreduce<U>(callbackfn, initialValue: U): Uoverload.Example (from issue):
Solution
Move the generic overload
reduce<U>before thereduce(initialValue: T)overload:Files Changed
src/lib/es5.d.ts-ReadonlyArrayandArrayinterfacessrc/lib/esnext.iterator.d.ts-IteratorinterfaceTest plan
reduce-related tests passFixes #7014
🤖 Generated with Claude Code