Move knip args #62865
Merged
Move knip args #62865
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
1 similar comment
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
jakebailey
approved these changes
Dec 9, 2025
There was a problem hiding this comment.
Pull request overview
This PR consolidates knip configuration by moving command-line arguments into the knip.jsonc configuration file. This improves maintainability by keeping all knip settings in a single location and simplifies the CLI invocation. Additionally, it removes an obsolete @knipignore tag from an unused function and cleans up a non-existent entry point.
- Moved
--tagsand--excludearguments from Herebyfile.mjs to knip.jsonc - Removed non-existent
.eslint-plugin-local.cjsentry point - Removed obsolete @knipignore tag from unused
hasTypeArgumentsfunction
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| knip.jsonc | Added exclude and tags configuration options, removed obsolete .eslint-plugin-local.cjs entry point |
| Herebyfile.mjs | Simplified knip task by removing CLI arguments now defined in config file |
| src/compiler/utilities.ts | Removed obsolete @knipignore tag from hasTypeArguments function |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
knipagainst the typescript codebase it's convenient to not have to add these flags on the CLI. Also good to have all config together in a single file.Also removed an obsolete
knipignoretag and an entry point that no longer exists.