feat(nuxt): Bump @sentry/vite-plugin and @sentry/rollup-plugin to 4.6.1
#18349
Conversation
Lms24
changed the title
@sentry/vite-plugin and @sentry/rollup-plugin to 4.6.1@sentry/vite-plugin and @sentry/rollup-plugin to 4.6.1
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
force-pushed
the
lms/deps-nuxt-plugins
branch
from
b5f6880 to
f3cf791
Compare
Lms24
force-pushed
the
lms/deps-nuxt-plugins
branch
from
f3cf791 to
2c39c62
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| project, | ||
| // same handling as in bundler plugins: https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/05084f214c763a05137d863ff5a05ef38254f68d/packages/bundler-plugin-core/src/build-plugin-manager.ts#L102-L103 | ||
| project: Array.isArray(project) ? project[0] : project, | ||
| ...sentryConfig.unstable_sentryVitePluginOptions, |
There was a problem hiding this comment.
Bug: Spread overwrites normalized project value
The SentryCli constructor carefully normalizes project from array to string on line 69, but then immediately spreads ...sentryConfig.unstable_sentryVitePluginOptions on line 70. Since unstable_sentryVitePluginOptions may contain its own project property (potentially an array), this spread overwrites the normalized value, defeating the purpose of the array-to-string conversion. The spread should come before the project property, not after.
| project, | ||
| // same handling as in bundler plugins: https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/05084f214c763a05137d863ff5a05ef38254f68d/packages/bundler-plugin-core/src/build-plugin-manager.ts#L102-L103 | ||
| project: Array.isArray(project) ? project[0] : project, | ||
| ...sentryConfig.unstable_sentryVitePluginOptions, |
There was a problem hiding this comment.
Bug: Spread overwrites normalized project value
The SentryCli constructor carefully normalizes project from array to string on line 69, but then immediately spreads ...sentryConfig.unstable_sentryVitePluginOptions on line 70. Since unstable_sentryVitePluginOptions may contain its own project property (potentially an array), this spread overwrites the normalized value, defeating the purpose of the array-to-string conversion. The spread should come before the project property, not after.
size-limit report 📦
|
#18270 bumps just the rollup plugin but we should bump both simultaneously.