WIP!!! Fix race condition caused by mstats replacing it with task_info #15501 #15595
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
| NSDate *collectionTime = [NSDate date]; | ||
|
|
||
| struct mstats ms = mstats(); | ||
| // Reading task_info is safer to call from any thread, including during high throughput networking activity. |
There was a problem hiding this comment.
nit: Do you mean that reading it is safer to call IT from any thread? Or is is safer than?
2 participants
WORK IN PROGRESS STILL VALIDATING / DRAFT!!!
This fix consists of using task_info rather than mstats which is a more modern way to measure memory usage, task_info should do a memory query that does not touch the allocator's internal state
This should fix issue #15501
Testing
API Changes