Sketch Lab: support version history #69984
Open
+86
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molly-moen
reviewed
Dec 10, 2025
Contributor
molly-moen
left a comment
molly-moen
left a comment
There was a problem hiding this comment.
Seems reasonable, one comment!
| if (onRestore) onRestore(startSources); | ||
| } else if (isLatest) { | ||
| dispatch(resetToCurrentVersion()); | ||
| if (onRestore) dispatch(resetToCurrentVersion({onRestore})); |
Contributor
There was a problem hiding this comment.
should onRestore be required here to call resetToCurrentVersion? As-is will this cause broken behavior in Web Lab 2/Python lab?
Contributor
Author
There was a problem hiding this comment.
Yes guessing it will, thanks for the callout. Think I was just trying to avoid TS errors. I will tidy and request review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds version history to Sketch Lab. The approach here was to pass our handler that updates sources in
SourcesContainerto the version history component as a prop. Ideally, we'd like to unify these approaches to managing sources at some point in the future.Links
Testing story
Tested manually that I could view/restore intermediate versions, the initial version (with "start over" warning modal), and go back to the current version. Also tested that viewing a version made the canvas readonly and that changes were not saved if the page was reloaded after viewing (but not restoring) an old version.
Follow-up work
There's a UI to created named versions with a description, which relies on setting a bit of Redux state (
hasEdited) that Sketch Lab doesn't support yet. To simplify things, I'll do that as a follow-up.