[ZEPPELIN-6358] Seperate environment config and shared utilities from #5101 #5128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dididy
force-pushed
the
e2e/notebook-base
branch
from
d0e0380 to
fc44d9c
Compare
dididy
commented
Dec 6, 2025
tbonelee
requested changes
Dec 8, 2025
dididy
force-pushed
the
e2e/notebook-base
branch
from
83424ae to
1f45f33
Compare
tbonelee
reviewed
Dec 9, 2025
.github/workflows/frontend.yml
Outdated
Comment on lines
116
to
119
| - name: Setup Zeppelin Configuration (Disable Git) | ||
| run: | | ||
| echo "Setting ZEPPELIN_NOTEBOOK_STORAGE environment variable" | ||
| echo "ZEPPELIN_NOTEBOOK_STORAGE=org.apache.zeppelin.notebook.repo.VFSNotebookRepo" >> $GITHUB_ENV |
Contributor
There was a problem hiding this comment.
Why set ZEPPELIN_NOTEBOOK_STORAGE in a separate step instead of in the job's env section?
run-playwright-e2e-tests:
env:
ZEPPELIN_NOTEBOOK_STORAGE: org.apache.zeppelin.notebook.repo.VFSNotebookRepoIs there a specific reason for the current approach?
Contributor
Author
There was a problem hiding this comment.
a07052f
Thanks for the suggestion. I’ve updated it to include it in the env step, which seemed like the better approach.
| // Find the test folder | ||
| const testFolders = data.body.filter( | ||
| (item: { path: string }) => | ||
| item.path && item.path.split(E2E_TEST_FOLDER)[0] === '/' && !item.path.includes(`~Trash`) |
Contributor
There was a problem hiding this comment.
This might be subjective, but item.path.split('/')[1] === E2E_TEST_FOLDER felt a bit easier for me to understand at a glance.
Using split('/') makes it clearer that we’re checking the first segment of the path.
Contributor
Author
There was a problem hiding this comment.
e6033e8
I’ve updated it according to the conditions you mentioned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In #5101, the amount of changes became too large, and a committer suggested splitting it into smaller parts. Since the updates related to the common test environment and shared utility functions have already proven to be stable, I separated those pieces into this dedicated PR.
This PR includes only the safe, standalone changes that improve the shared E2E environment and utilities.
[Summary of Changes]
Refined and separated E2E test environment setup
Improved global setup/teardown
ZEPPELIN_E2E_TEST_NOTEBOOK_DIRlocally, the server has to be restarted at least once, which feels a bit odd to enforce during E2E test execution. To make things less messy from a UI perspective, I reorganized the structure so that all tests are collected underE2E_TEST_FOLDERinstead.Added folder/notebook initialization and cleanup logic
npm run e2e:cleanup(automatically run this once the tests are finished)Extracted shared utilities and constants
E2E_TEST_FOLDER)Updated GitHub Actions (
frontend.yml)Playwright reportfrom 30 days to 3 daysUpdated Playwright / ESLint configurations
What type of PR is it?
Improvement
Refactoring
Todos
What is the Jira issue?
ZEPPELIN-6358
How should this be tested?
cd zeppelin-web-angular nvm use npm run start npm run e2e npm run e2e:cleanupScreenshots (if appropriate)
Questions: