Prefix inlined vendor libs with VendorPrefix #212
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the PHP Toolkit is used alongside other plugins or WP-CLI packages that bundle the same libraries (like
rowbot/url,brick/math, orpsr/log), PHP class redefinition errors occur because both distributions load identically-named classes.This change adds a
VendorPrefix\prefix to all bundled vendor namespaces, so classes likeRowbot\URL\URLbecomeVendorPrefix\Rowbot\URL\URL. This isolates our dependencies and allows the importer to coexist with any other package that bundles the same libraries.Test plan
Confirm all the CI checks are green.
Related to WordPress/wordpress-importer#248 and https://github.com/WordPress/wordpress-importer/issue/245