add eaglercraft as alternative, fix types again

zardoy · zardoy · commit 9e7711e386ef · 2024-09-03T03:15:17.000+03:00
diff --git a/README.MD b/README.MD
@@ -188,3 +188,4 @@ General:
 ### Alternatives
 
 - [https://github.com/ClassiCube/ClassiCube](ClassiCube - Better C# Rewrite) [DEMO](https://www.classicube.net/server/play/?warned=true)
+- [https://m.eaglercraft.com/](EaglerCraft) - Eaglercraft runnable on mobile (real Minecraft in the browser)
diff --git a/prismarine-viewer/viewer/lib/mesher/models.ts b/prismarine-viewer/viewer/lib/mesher/models.ts
@@ -410,7 +410,7 @@ export function getSectionGeometry (sx, sy, sz, world: World) {
     tiles: {},
     // todo this can be removed here
     signs: {},
-    isFull: true,
+    // isFull: true,
     highestBlocks: {},
     hadErrors: false
   }
diff --git a/prismarine-viewer/viewer/lib/mesher/shared.ts b/prismarine-viewer/viewer/lib/mesher/shared.ts
@@ -29,7 +29,7 @@ export type MesherGeometryOutput = {
   indices: number[],
   tiles: Record<string, BlockType>,
   signs: Record<string, any>,
-  isFull: boolean
+  // isFull: boolean
   highestBlocks: Record<string, { y: number, name: string }>
   hadErrors: boolean
 }
diff --git a/prismarine-viewer/viewer/lib/mesher/test/mesherTester.ts b/prismarine-viewer/viewer/lib/mesher/test/mesherTester.ts
@@ -41,7 +41,7 @@ export const setup = (version, initialBlocks: Array<[number[], string]>) => {
   reload()
 
   const getLights = () => {
-    return Object.fromEntries(getGeometry().faces.map(({ face, light }) => ([face, light * 15 - 2])))
+    return Object.fromEntries(getGeometry().faces.map(({ face, light }) => ([face, (light ?? 0) * 15 - 2])))
   }
 
   const setLight = (x: number, y: number, z: number, val = 0) => {

Original file line number	Diff line number	Diff line change
`@@ -188,3 +188,4 @@ General:`
`188`	`188`	`### Alternatives`
`189`	`189`
`190`	`190`	`- [https://github.com/ClassiCube/ClassiCube](ClassiCube - Better C# Rewrite) [DEMO](https://www.classicube.net/server/play/?warned=true)`
	`191`	`+- [https://m.eaglercraft.com/](EaglerCraft) - Eaglercraft runnable on mobile (real Minecraft in the browser)`
Original file line number	Diff line number	Diff line change
`@@ -410,7 +410,7 @@ export function getSectionGeometry (sx, sy, sz, world: World) {`
`410`	`410`	`tiles: {},`
`411`	`411`	`// todo this can be removed here`
`412`	`412`	`signs: {},`
`413`		`- isFull: true,`
	`413`	`+ // isFull: true,`
`414`	`414`	`highestBlocks: {},`
`415`	`415`	`hadErrors: false`
`416`	`416`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export type MesherGeometryOutput = {`
`29`	`29`	`indices: number[],`
`30`	`30`	`tiles: Record<string, BlockType>,`
`31`	`31`	`signs: Record<string, any>,`
`32`		`- isFull: boolean`
	`32`	`+ // isFull: boolean`
`33`	`33`	`highestBlocks: Record<string, { y: number, name: string }>`
`34`	`34`	`hadErrors: boolean`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ export const setup = (version, initialBlocks: Array<[number[], string]>) => {`
`41`	`41`	`reload()`
`42`	`42`
`43`	`43`	`const getLights = () => {`
`44`		`- return Object.fromEntries(getGeometry().faces.map(({ face, light }) => ([face, light * 15 - 2])))`
	`44`	`+ return Object.fromEntries(getGeometry().faces.map(({ face, light }) => ([face, (light ?? 0) * 15 - 2])))`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`const setLight = (x: number, y: number, z: number, val = 0) => {`