Skip to content

Commit 6f07a90

Browse files
committed
Ban non-ambient uses of module keyword
1 parent 9707ef2 commit 6f07a90

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/compiler/checker.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,6 @@ import {
347347
getNamespaceDeclarationNode,
348348
getNewTargetContainer,
349349
getNonAugmentationDeclaration,
350-
getNonModifierTokenPosOfNode,
351350
getNormalizedAbsolutePath,
352351
getObjectFlags,
353352
getOriginalNode,
@@ -48103,13 +48102,8 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
4810348102

4810448103
if (isIdentifier(node.name)) {
4810548104
checkCollisionsForDeclarationName(node, node.name);
48106-
if (!(node.flags & (NodeFlags.Namespace | NodeFlags.GlobalAugmentation))) {
48107-
const sourceFile = getSourceFileOfNode(node);
48108-
const pos = getNonModifierTokenPosOfNode(node);
48109-
const span = getSpanOfTokenAtPosition(sourceFile, pos);
48110-
suggestionDiagnostics.add(
48111-
createFileDiagnostic(sourceFile, span.start, span.length, Diagnostics.A_namespace_declaration_should_not_be_declared_using_the_module_keyword_Please_use_the_namespace_keyword_instead),
48112-
);
48105+
if (!(node.flags & (NodeFlags.Namespace | NodeFlags.GlobalAugmentation | NodeFlags.Ambient))) {
48106+
error(node.name, Diagnostics.A_namespace_declaration_should_not_be_declared_using_the_module_keyword_Please_use_the_namespace_keyword_instead);
4811348107
}
4811448108
}
4811548109

0 commit comments

Comments
 (0)