Skip to content

Commit 3544dd7

Browse files
authored
Fix ContextFlags compile error (#62855)
1 parent 69a0879 commit 3544dd7

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -316,17 +316,23 @@ jobs:
316316
working-directory: ./pr
317317

318318
- run: npm ci
319+
id: base-npm-ci
320+
continue-on-error: true
319321
working-directory: ./base
320322

321323
- run: npx hereby lkg
322324
working-directory: ./pr
323325

324326
- run: npx hereby lkg
327+
id: base-lkg
328+
continue-on-error: true
329+
if: ${{ steps.base-npm-ci.outcome == 'success' }}
325330
working-directory: ./base
326331

327332
- run: |
328333
echo "See $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID for more info."
329334
node ./pr/scripts/checkPackageSize.mjs ./base ./pr >> $GITHUB_STEP_SUMMARY
335+
if: ${{ steps.base-lkg.outcome == 'success' }}
330336
331337
misc:
332338
runs-on: ubuntu-latest

src/services/stringCompletions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,7 @@ function getStringLiteralCompletionEntries(sourceFile: SourceFile, node: StringL
434434
const uniques = new Set<string>();
435435
const stringLiteralTypes = concatenate(
436436
getStringLiteralTypes(typeChecker.getContextualType(node, ContextFlags.None), uniques),
437-
getStringLiteralTypes(typeChecker.getContextualType(node, ContextFlags.Completions), uniques),
437+
getStringLiteralTypes(typeChecker.getContextualType(node, ContextFlags.IgnoreNodeInferences), uniques),
438438
);
439439
return toStringLiteralCompletionsFromTypes(stringLiteralTypes);
440440
}

0 commit comments

Comments
 (0)