Skip to content

Missing safeguard pre soc boards: CBFS_SIZE greater than BIOS region in the IFD #2031

@gaspar-ilom

Description

@gaspar-ilom

When enabling NRI for the Haswell boards we discovered a bug that boards did build but with undetermined behavior when CBFS_SIZE would not match the BIOS region in the IFD. See #2025

I opened a ticket to get those safeguards to work, but to no avail so far. Although we have figured out why they were not effective, there is no fix yet. As soon as there is, we should integrate it here for all pre soc boards.
https://ticket.coreboot.org/issues/617

My current branch to test the safeguards (haswell boards have invalid CBFS_SIZE, and the W541 enables IFD validation, so build should only fail for that board with an appropriate error.) Not working yet. https://github.com/gaspar-ilom/heads/tree/try-cbfs-sanity-check-patch

The analysis should happen upstream, just tracking it here to make it visible in Heads and so that others can contribute and integrate it here when its ready.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions