rotation bids fix, fix int and no random, why use this idk (#146)

* Fix crash if auctionsGuidsToConsider.size() < config->GetBidsPerInterval()

* fix crash if auctionsGuidsToConsider.size() > config->GetBidsPerInterval()

* FIx

* Fix

Signed-off-by: lotjib <parasolka1990@gmail.com>

* fix

* fix crash

* fix

* Fix Crash Error

* Fix

* Fix Crash

* Fix Crash Error

* fix

* Fix Crash if BuyBidsPerInterval > 1 and "FROM `acore_characters`.`auctionhouse`
WHERE houseid=AHID AND itemowner<>AHBOTID AND buyguid=0"

* Fix

* Fix

* Fix

* Fix

* Revert

* Fix

* Fix

* hello test

* FF

* FF

* ff

* Fix

* ff

* ff

* F

* fix

* ff

* ff

* Fix Crash

* fix

* f

* ff

* ff

* ff

* ff

* ff

* fix

---------

Signed-off-by: lotjib <parasolka1990@gmail.com>

Author: lotjib

src/AuctionHouseBot.cpp

@@ -213,12 +213,12 @@ void AuctionHouseBot::Buy(Player* AHBplayer, AHBConfig* config, WorldSession* se
     //
 
     AuctionHouseObject* auctionHouseObject = sAuctionMgr->GetAuctionsMap(config->GetAHFID());
-    std::vector<uint32> auctionsGuidsToConsider;
+    std::set<uint32> auctionsGuidsToConsider;
 
     do
     {
         uint32 autionGuid = ahContentQueryResult->Fetch()->Get<uint32>();
-        auctionsGuidsToConsider.push_back(autionGuid);
+        auctionsGuidsToConsider.insert(autionGuid);
     } while (ahContentQueryResult->NextRow());
 
     //
@@ -244,29 +244,21 @@ void AuctionHouseBot::Buy(Player* AHBplayer, AHBConfig* config, WorldSession* se
         LOG_INFO("module", "AHBot [{}]: Considering {} auctions per interval to bid on.", _id, config->GetBidsPerInterval());
     }
 
-    for (
-        uint32 count = 1;
-        count <= config->GetBidsPerInterval() && !auctionsGuidsToConsider.empty();
-        ++count
-    ) {
-        //
-        // Choose a random auction from possible auctions
-        //
-
-        uint32 randomIndex = urand(0, auctionsGuidsToConsider.size() - 1);
-
-        std::vector<uint32>::iterator itBegin = auctionsGuidsToConsider.begin();
-        //std::advance(it, randomIndex);
-
-        uint32 auctionID = auctionsGuidsToConsider.at(randomIndex);
+    for (uint32 count = 1; count <= config->GetBidsPerInterval(); ++count)
+    {
+        if (auctionsGuidsToConsider.empty()) {
+            return;
+        }
 
+        std::set<uint32>::iterator it = auctionsGuidsToConsider.begin();
+        std::advance(it, 0);
+        uint32 auctionID = *it;
         AuctionEntry* auction = auctionHouseObject->GetAuction(auctionID);
-
+        
         //
         // Prevent to bid again on the same auction
         //
-
-        auctionsGuidsToConsider.erase(itBegin + randomIndex);
+        auctionsGuidsToConsider.erase(it);
 
         if (!auction)
         {
@@ -312,14 +304,15 @@ void AuctionHouseBot::Buy(Player* AHBplayer, AHBConfig* config, WorldSession* se
         //
         // Determine current price.
         //
-        uint32 currentPrice = auction->bid ? auction->bid : auction->startbid;
+
+        uint32 currentPrice = static_cast<uint32>(auction->bid ? auction->bid : auction->startbid);
 
         //
         // Determine maximum bid and skip auctions with too high a currentPrice.
         //
 
-        double basePrice = config->UseBuyPriceForBuyer ? prototype->BuyPrice : prototype->SellPrice;
-        double maximumBid = basePrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality);
+        uint32 basePrice = static_cast<uint32>(config->UseBuyPriceForBuyer ? prototype->BuyPrice : prototype->SellPrice);
+        uint32 maximumBid = static_cast<uint32>(basePrice * pItem->GetCount() * config->GetBuyerPrice(prototype->Quality));
 
         if (config->TraceBuyer)
         {
@@ -406,7 +399,7 @@ void AuctionHouseBot::Buy(Player* AHBplayer, AHBConfig* config, WorldSession* se
         uint32 minimumOutbid = auction->GetAuctionOutBid();
         if ((currentPrice + minimumOutbid) > bidPrice)
         {
-            bidPrice = currentPrice + minimumOutbid;
+            bidPrice = static_cast<uint32>(currentPrice + minimumOutbid);
         }
 
         if (bidPrice > maximumBid)
@@ -415,7 +408,7 @@ void AuctionHouseBot::Buy(Player* AHBplayer, AHBConfig* config, WorldSession* se
             {
                 LOG_INFO("module", "AHBot [{}]: Bid was above bidMax for item={} AH={}", _id, auction->item_guid.ToString(), config->GetAHID());
             }
-            bidPrice = maximumBid;
+            bidPrice = static_cast<uint32>(maximumBid);
         }
 
         if (config->DebugOutBuyer)

src/AuctionHouseBot.h

@@ -50,7 +50,6 @@ class AuctionHouseBot
     //
     // Main operations
     //
-
     void Sell(Player *AHBplayer, AHBConfig *config);
     void Buy (Player *AHBplayer, AHBConfig *config, WorldSession *session);